Consistently allow Locale objects in locale list params#52996
Merged
sandersn merged 2 commits intomicrosoft:mainfrom Nov 29, 2023
Merged
Consistently allow Locale objects in locale list params#52996sandersn merged 2 commits intomicrosoft:mainfrom
sandersn merged 2 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
Contributor
Author
|
@microsoft-github-policy-service agree company="Clearly Local" |
lionel-rowe
commented
Mar 7, 2023
typescript-bot
removed
the
For Uncommitted Bug
lionel-rowe
force-pushed
the
fix/locales-argument
branch
2 times, most recently
from
c232d54 to
ab8be33
Compare
lionel-rowe
force-pushed
the
fix/locales-argument
branch
from
ab8be33 to
569e080
Compare
Contributor
Author
|
@sandersn Any chance of getting this merged soon? If nothing else, it'd be good to be able to close the attached issue, as it seems to be a magnet for people mistakenly thinking it's about their own |
sandersn
requested changes
Nov 28, 2023
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Looks like an improvement. I just have some questions about interface merging and the BC47LanguageTag alias.
sandersn
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52946
I've also removed the type
BCP47LanguageTagin favor ofUnicodeBCP47LocaleIdentifier— not sure why there were 2 distinct types for this in the first place, especially given that both are just aliases ofstring. In any case, the correct term is "locale identifier", not "language tag" — BCP 47 locale identifiers are a subset of BCP 47 language tags, and language tags that aren't locale identifiers aren't supported byIntl.BCP47LanguageTagcould alternatively be deprecated rather than removed, to mitigate the unlikely case of userland code using theIntl.BCP47LanguageTagtype... not sure if that's a necessary consideration, though.